Profile Card built with React & Emotion on Live Coding

Community feedback

• 

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  Hi Carlos,

  Well done!

  According to your question, the circles are a bit tricky in this challenge. I have used pseudo-elements, position absolute, vw and vh, background url, transform translate and @media (in your solution they are not very stable on different devices). Also, you can add better box-shadow, fix the HTML issue by adding the h1 tag to the section. Generally semantic tags matter, divs are semantically inert elements — elements that don’t really do or say anything.

  That's it from me. Ps. Don't forget to upvote any comments on here that you find helpful.

  Greetings :D

  2

  ---

  

  P

  Carlos Loureda•150

  @carloslouredaPosted almost 4 years ago

  Thanks SzymonRojek.

  I applied your recommended changes and used vw for the background-images position. I will work more on the box-shadow staff on next project.

  Thanks for your tips!

  0