Profile card builded with SASS

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello, Fernanda Laguna Hermida! 👋

  Nice work on this challenge! 🙌 Your solution is responsive and looks great! 👍

  Regarding your question, I don't recommend changing the html or the :root font size. It can cause huge accessibility implications for those users with different font sizes or zoom requirements. I suggest reading this article by Josh Comeau where he writes about the problem of the 62.5% trick (and more!). Also, I recommend reading what an accessibility expert (Grace Snow) has said about it.

  I notice that you are using sub element for the statistic category. I would not recommend using it because sub element should be used in mathematical variable numbers or number of atoms of a given element within a chemical formula. You can learn more about the sub element on the MDN documentation.

  So, I recommend making the statistic a list element instead. If the site has no styling then a list element is a good element for this. After that, you can wrap the number statistic and the category statistic with span. The number statistic should not be a heading.

  • 80K followers
  • 803K likes
  • 1.4K photos

  I hope this helps! Happy coding! 😁

  Marked as helpful

  1

  ---

  

  Fernanda•180

  @ferlagherPosted over 2 years ago

  @vanzasetia Thank you so much for your feedbak! I've read that it is a bad practise, but didn't know why. The calc trick looks better, I will try it! I didn't know that about the sub neither. I still have a lot to learn about semantic html. I'm trying to imrpove the accesibilty of my code.

  Your comment was really helpful, thank you, and have a nice day! :)

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @ferlagher Happy to hear that was helpful! 😊 Also, have a nice day too! 😄

  0