Design comparison
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
BACKGROUND iMAGE 📸:
- Looks like the background images has not been properly set yet, they are misplaced due to the usage of individual
div
elements. Actually there's an easy way to handle this problem with positioning the background images
- So let me share my css snippet which helps you to easily apply the
background color
with thebackground svg
they provided to place perfectly as same as design.
- Add the following style rule to your css, after completing these steps you can experience the changes.
body { background: url(./images/bg-pattern-top.svg), url(./images/bg-pattern-bottom.svg); background-position: right 52vw bottom 35vh, left 48vw top 52vh; background-repeat: no-repeat, no-repeat; background-color: hsl(185deg, 75%, 39%); }
- Now you can remove these individual
div
elements from thehtml
and their styles fromcss
<div class="minor"></div> <div class="minor-2"></div> .minor { content: url(./bg-pattern-top.svg); position: absolute; height: 500px; top: -150px; left: -100px; } .minor-2 { content: url(./bg-pattern-bottom.svg); position: absolute; height: 500px; bottom: -280px; right: -10px; }
- Tip, Don't forget to generate a new screenshot after editing the
css
file
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@OlawalefarukPosted over 1 year agoI really appreciatethis brother. Jazakumullah khairan@0xAbdulKhalid
0@OlawalefarukPosted over 1 year agoI am done. Thanks brother. can you please share me your whatsapp contact? @0xAbdulKhalid
0@0xabdulkhaliqPosted over 1 year agoAssalamu Alaikum Warahmatullahi Wabarakatuh Brother @Olawalefaruk
Sorry to say that i can't provide my whatsapp contact, but we can connect on discord to chat regarding web dev
0@OlawalefarukPosted over 1 year agowa alaykum salam warahmotullah wabarakatuh brother@0xAbdulKhalid
no problem bro
0@OlawalefarukPosted over 1 year agowa alaykum salam warahmotullah wabarakatuh brother@0xAbdulKhalid
no problem bro
0@OlawalefarukPosted over 1 year agowa alaykum salam warahmotullah wabarakatuh brother@0xAbdulKhalid
no problem bro
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord