Design comparison
SolutionDesign
Solution retrospective
Feel free for suggestions! ♥
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HEIGHT 📐:
- Use
min-height: 100vh
formain
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens.
- For example; if we set
height: 100vh
then themain
will have100vh
height no matter what. Even if the content spans more than100vh
.
- But if we set
min-height: 100vh
then themain
will start at100vh
, if the content pushes themain
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @Davidmide02Posted over 1 year ago
You did a pretty cool job!
Even the report showed no issue. You can try to pick up more advance level project to further flex your knowledge. Hope this is helpful?
1@AnaLuisaFavPosted over 1 year ago@Davidmide02 Thanks! I will do that soon. I plan on doing all of the newbie challenge just to feel like I've completed everything 🤭🤭
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord