Profile Card

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEIGHT 📐:

  • Use min-height: 100vh for main instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the main will have 100vh height no matter what. Even if the content spans more than 100vh.

  ---

  • But if we set min-height: 100vh then the main will start at 100vh, if the content pushes the main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Ana Luisa•290

  @AnaLuisaFavPosted over 1 year ago

  @0xAbdulKhalid thanks! I'll fix it :D

  0
• 

  David Adenusi•370

  @Davidmide02Posted over 1 year ago

  You did a pretty cool job!

  Even the report showed no issue. You can try to pick up more advance level project to further flex your knowledge. Hope this is helpful?

  1

  ---

  

  Ana Luisa•290

  @AnaLuisaFavPosted over 1 year ago

  @Davidmide02 Thanks! I will do that soon. I plan on doing all of the newbie challenge just to feel like I've completed everything 🤭🤭

  1