Profile card

Community feedback

• 

  Renszo Camacho•1,615

  @RenszCamachoPosted almost 4 years ago

  Hiya 👋🏻 moibrahem98.

  Good job mate 👏👏👏. You have done a fantastic job on this challenge 👌, place properly the background image is quite tricky.

  Just a few suggestions IMHO.

  • Add an alternative text to your images. <img class="person" src="images/image-victor.jpg" alt="victor" />

  • I would add a CSS reset, to avoid some annoying margins.

  * { margin: 0; padding: 0; box-sizing: border-box; }

  • To place the background-images:

  body { background-image: url(../images/bg-pattern-top.svg), url(../images/bg-pattern-bottom.svg); background-position: right 50vw bottom 50vh, left 50vw top 50vh; background-repeat: no-repeat; background-color: hsl(185, 75%, 39%); display: flex; justify-content: center; align-items: center; width: 100%; height: 100vh; }

  • To center the card.

  .card__body { width: inherit; height: inherit; display: flex; justify-content: center; align-items: center; }

  Happy coding🧑‍💻

  1

  ---

  

  Mohamed Ibrahem•20

  @moibrahem98Posted almost 4 years ago

  @RenszCamacho Words cannot express how grateful I am for your kindness and generosity <3 <3 <3

  0