Profil card component

Community feedback

• 

  David Ouma•270

  @daudi13Posted almost 4 years ago

  Hi, I've taken a look at your code and I Just have a few comments and suggestions.

  1. Your code HTML code is really impressive for a 3 week old beginner.
  2. I want you to know there are many ways of solving the same problem don't get scared of sophisticated code many are just sphagetti code.

  For suggestions i suggest the following:

  1. Give a class to the div immediately after the body you can give it any class name you want but .wrapper or .container are used universally.
  2. As a beginner I suggest you learn BEM naming conventions as early as you can. because 1) it will make working on your CSS much easier and 2) it's gonna be helpful when you start working with Javascript. It is really easy to muster.
  3. When resting default values like margin, box-sizing and padding it is safe to include ::before and ::after.
  4. I know you're still new in the game but after you learn and muster Flexbox and Grid things will start getting much easier. I wish you good luck in your journey and have fun. Happy coding. you can upvote this comment if you found it helpful.

  1

  ---

  

  Kristýna•40

  @KristynRihoPosted almost 4 years ago

  @daudi13 Hello, thank you very much for your feedback and for the tips!

  0