Producy Preview Card (fm)

Community feedback

• 

  Adriano•38,160

  @AdrianoEscarabotePosted about 1 month ago

  Hi fowzia-mehedi, hope you're doing well! I loved how your project turned out, but I’ve got a few suggestions that could be useful:

  Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  The rest is fantastic.

  Hopefully, you'll find it helpful. 👍

  Marked as helpful

  1

  ---

  

  fowzia-mehedi•60

  @fowzia-mehediPosted about 1 month ago

  @AdrianoEscarabote Thanks again Adriano.Your suggestions are always helpful. ^^

  1
• 

  Sylwia•240

  @LesSylPosted about 1 month ago

  Hi, great work. Your solution is very good. I have a couple of suggestions:

  1. why did you put the styles in html? They should be in a separate file. You can read more here: CSS basics
  2. it is good practice to use a naming convention such as BEM (Block, Element, Modifier) as it makes the CSS more structured, readable and easier to maintain. BEM helps to clearly understand the purpose of each class, avoid naming conflicts and create reusable components, leading to a more scalable code base. More details here: BEM. Good luck!

  Marked as helpful

  1

  ---

  

  fowzia-mehedi•60

  @fowzia-mehediPosted about 1 month ago

  @LesSyl Hi! Thank you for your suggestions^^

  0