Product-view card

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  PiCTURE TAG 📸:

  • Looks like you're currently using media queries for swapping different version of image, So let me introduce the picture element.

  ---

  • The <picture> tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.

  ---

  • Example:

  <picture>
  <source media="(max-width: 768px)" srcset="small-image.jpg">
  <source media="(min-width: 769px)" srcset="large-image.jpg">
  <img src="fallback-image.jpg" alt="Example image">
  </picture>
  

  ---

  • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.

  ---

  • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• Account deleted

  Hello Coder🙂

  your solution is great 🎉

  But you used the wrong method to switch images and there are some better ways are available to handle the image switch problem

  You can try <picture> tag to switch image

  Picture tag :

  <picture>
  
  <source media="(min-width: 597px)"
  srcset="./images/image-product-desktop.jpg ">
  
  
  <source media="(min-width: 0px)" 
  srcset=" ./images/image-product-mobile.jpg">
  
  <img src="./images/image-product-mobile.jpg" alt="Product_image">
  
  </picture>
  
  

  <h1> tag :

  It is mandatory to use a <h1> tag in your solution because <h1> tag is most important aspect in accessibility and it helps screen reader to navigate with your page in easy way

  And H1 tags also help Google to understand the structure of a page. So if you're using H1s as Google recommends for your page title or content heading, your H1 is effectively telling Google “here's what my page is about.

  and you also can take a look of my solution✨ that will definitely going to help you 👀

  I hope that will be helpful for you✌️

  Marked as helpful

  0

  ---

  

  mayank•70

  @mayank-s7Posted over 1 year ago

  Thanks buddy@MrSandipSharma

  0

  Account deleted

  @mayank-s7

  I am glad that was helpful for you 😊

  0