Design comparison
Solution retrospective
i made it responsive that's the biggest achievement for me.
What challenges did you encounter, and how did you overcome them?i encountered some problems in making it responsive but I did it anyways
What specific areas of your project would you like help with?i require more help on responsiveness so that I can master it.
Community feedback
- @danielmrz-devPosted 7 months ago
Hello there!
Congrats on completing the challenge! β
Your project looks great!
I have a suggestion about your code that might interest you:
π You can use the
<picture>
tag when you have different versions of the same image.Using the
<picture>
tag will help load the correct image to the user's device, saving bandwidth and improving performance.Example:
<picture> <source media="(min-width: 768px)" srcset="{desktop image path here}"> <img src="{mobile image path here}" alt="{alternative text here}"> </picture>
I hope this helps!
Other than that, excellent work!
Marked as helpful0@thebigfatpaandaPosted 7 months ago@danielmrz-dev
Thankyou!!, that's new information for me.
0 - @0xabdulkhaliqPosted 7 months ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have a suggestion regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- This solution contains some minor semantic mistakes which may cause accessibility issues
- The
<p id="p1">PERFUME</p>
, must want to be changed to normal case likePerfume
- Itβs not great for screen readers, because uppercase text will be read out as individual letters (like abbreviations). So CSS is read as C.S.S. Just as PERFUME would be read as P.E.R.F.U.M.E, not as the word Perfume
- You can read more about that in this article on Medium
- Don't worry we can use
text-transform: uppercase
to transform the letter andletter-spacing: 1rem
for the textPerfume
- And another thing that the old price is not being properly announced, you have used
p
element for that (<p id="oldprice">$169.99</p>
).
- Actually there's a native html element which comes handy in these situations. it is
del
element
- So you can use like this
<del>$169.99</del>
- These are the tips which improves the accessibility in real world situations.
- If you have any questions or need further clarification, you can always check out
my submission
and/or feel free to reach out to me.
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@thebigfatpaandaPosted 7 months ago@0xabdulkhalid
Thanks, man!!! , this will help me a lot for future projects.
0@0xabdulkhaliqPosted 7 months agoHey @thebigfatpaanda, You're welcome Man! π€
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord