Product-review-card

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Mustafa, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  A better way to work this solution image, the product image is by using <picture> to wrap it on the html instead of using it as <img> or background-image (with the css). Using <picture> you wrap both images (desktop and mobile) and have more control over it, since you can set in the html when the images changes setting the screen size for each image.ote that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image.

  Here’s the documentation and the guide to use this tag: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Mustafa Anandwala•30

  @Mussu007Posted about 2 years ago

  @correlucas Thank you for the feedback, I will implement this.

  0

  

  Mustafa Anandwala•30

  @Mussu007Posted about 2 years ago

  @correlucas Thank you for the feedback, I will implement this.

  1
• 

  Kawsar Ahmed Fahad•2,660

  @faha1999Posted about 2 years ago

  Hello, Mustafa Anandwala Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:

  • You might want to use semantic tags like the <main> to wrap your code, instead of div. like

  <main class="container">
  </main>
  

  This would help improve accessibility.

  • add align-items: center; to the body

  • remove margin from the .container

  • Instead of using px, use relative units like rem or em to get better performance when the information on your page needs to be resized for multiple screens and devices. REM and EM apply to all sizes, not just font-size. You can code your entire page in px and then, at the very end, use the VsCode plugin px to rem to perform the automatic conversion px to rem

  • This is my solution of this challenge live, repo

  I hope it will work. Happy coding.

  Marked as helpful

  1

  ---

  

  Mustafa Anandwala•30

  @Mussu007Posted about 2 years ago

  @faha1999 Thank you for the feedback, I will implement this :)

  0