Design comparison
Solution retrospective
any suggestions is much appreciated
Community feedback
- @correlucasPosted over 2 years ago
๐พHello Faraz, congratulations for your solution!
Your solution is really good, but there are some design details you can improve.
Here's my tips for your:
1.Add a general
border-radius
to the container usingborder-radius: 12px
and for the imageborder-radius: 12px 0 0 12px;
2.The image isn't scaling correct and is losing its proportion because you've set
min-height
you don;t need to set theheight
just adddisplay: block
and the width, see the fixes below:img { display: block; max-width: 100%; /* min-height: 100%; */ border-radius: 12px 0 0 12px; }
Hope it helps and happy coding!
Marked as helpful0@GeekkyCoderPosted over 2 years ago@correlucas thank you for highlighting some fixings!
1@correlucasPosted over 2 years ago@GeekkyCoder You're welcome Faraz, happy to hear that!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord