Product-preview-card-component-solution

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • The width: 100% property for body element is not necessary. because it's a block level element which will take the full width of the page by default.

  ---

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Panji•2,090

  @pperdanaPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge!

  • I have feedback on your code that could take it to the next level. 🚀

  🔎 My suggestions for best practices for your code

  • Use classes and IDs: Use classes and IDs to define styles that can be applied to multiple elements. This way, you can avoid repeating styles for each element and instead define the style once and apply it to all relevant elements.

  • Use inheritance: Use inheritance to avoid repeating styles for child elements that inherit styles from their parent elements. This can help reduce the amount of CSS code needed to style a page.

  • Use variables: Use variables to store values that are used multiple times in your CSS code, such as colors or font sizes. This way, you can change the value in one place and have it applied throughout your CSS code.

  • Use preprocessors: CSS preprocessors like Sass or Less allow you to write more efficient CSS code

  I hope you find it useful! 😄

  Happy coding🤖

  0