Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

product-preview-card-component-main with css flex, sass

@matheusmorenocf

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


At first I put the product image in the html, but due to the responsiveness I realized that it would be easier to use the product as a background image so I could change it only with the css when the screen shrinks.

I saw some tips in my last challenge, they said to use rem or em instead of px, is there any way to convert more easily?

I stop using px in places like width and height too?

I appreciate any tips that can help me.

Community feedback

Lucas 👾 104,420

@correlucas

Posted

👾Hello @matheusmorenocf, Congratulations on completing this challenge!

Your solution its almost done and I’ve some tips to help you to improve it:

I saw that for some properties you’ve used rem and for others px. In this case, it is better to use only one kind of unit to have a better organization for your code. relative units as rem or em have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.

THE PICTURE TAG is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

✌️ I hope this helps you and happy coding!

0
Austin 160

@Ausranking

Posted

Work well done @matheusmorenocf in your body style, I saw min-width:600px width:30% I suggest it better be max-width: 600px or width: 600px I suggest you include more semantics in your HTML such as "article" , "aside" and minimize the use of divs Good Job!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord