product-preview-card-component-main with css flex, sass

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @matheusmorenocf, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  I saw that for some properties you’ve used rem and for others px. In this case, it is better to use only one kind of unit to have a better organization for your code. relative units as rem or em have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.

  THE PICTURE TAG is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  ✌️ I hope this helps you and happy coding!

  0
• 

  Austin•160

  @AusrankingPosted about 2 years ago

  Work well done @matheusmorenocf in your body style, I saw min-width:600px width:30% I suggest it better be max-width: 600px or width: 600px I suggest you include more semantics in your HTML such as "article" , "aside" and minimize the use of divs Good Job!

  0