Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

product-preview-card-component-main

Welliton Sanβ€’ 170

@Kira-Sann

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


projeto relativamente simples deem dicas de no que posso melhorar

Community feedback

Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

CSS 🎨:

  • Looks like the <footer"> element has been placed bottom using margin. So let me explain, How you can place the component at bottom with using fixed positioning for footer
  • Luckily you already used Flex layout of css to center the component, So you just want to add fixed position for <footer> element to place it in bottom of the page
.attribution {
   position: fixed;
   bottom: 1em;
}
  • Now remove these styles, after removing you can able to see the changes
.attribution {
  margin: 4rem 0;
}
  • Now your component has been properly at bottom

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

0

Welliton Sanβ€’ 170

@Kira-Sann

Posted

nΓ£o funciona sua dica, o footer fica fixo na tela e fica sobrepondo o conteΓΊdo da pagina se der zoom e em telas menores

@0xAbdulKhalid

0
Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

@Kira-Sann The code i shared above is for Desktop devices

Here is the corrected code which may work fine for both Desktop & Mobile devices.

  • First add these to body
body {
  position: relative;
}
  • Then add these to footer
footer {
  position: absolute;
  bottom: 1em;
}
  • Now your footer will not be overlapped with the component. cheers

PS: Do you know english or not ?, cuz i want to use translators to translate

Hope you find this feedback helpful!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord