Design comparison
Solution retrospective
projeto relativamente simples deem dicas de no que posso melhorar
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS π¨:
- Looks like the
<footer">
element has been placed bottom usingmargin
. So let me explain, How you can place the component at bottom with usingfixed
positioning forfooter
- Luckily you already used
Flex
layout ofcss
to center the component, So you just want to addfixed
position for<footer>
element to place it in bottom of the page
.attribution { position: fixed; bottom: 1em; }
- Now remove these styles, after removing you can able to see the changes
.attribution { margin: 4rem 0; }
- Now your component has been properly at bottom
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
0@Kira-SannPosted over 1 year agonΓ£o funciona sua dica, o footer fica fixo na tela e fica sobrepondo o conteΓΊdo da pagina se der zoom e em telas menores
@0xAbdulKhalid
0@0xabdulkhaliqPosted over 1 year ago@Kira-Sann The code i shared above is for Desktop devices
Here is the corrected code which may work fine for both Desktop & Mobile devices.
- First add these to
body
body { position: relative; }
- Then add these to
footer
footer { position: absolute; bottom: 1em; }
- Now your footer will not be overlapped with the component. cheers
PS: Do you know english or not ?, cuz i want to use translators to translate
Hope you find this feedback helpful!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord