product-preview-card-component-main

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @QBERT18, some suggestions to improve you code:

  • When you use images/icons, you want to include an Alt text tag with them. Inside that Alt Tag you want to describe what the image is; they need to be readable. Assume you’re describing the image/icon to someone.

  If the image/icon is decorative, then you will leave the Alt tag blank; alt=“”

  • The old price isnt being announce properly to screenreaders. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.

  • Your CSS Reset is extremely bare. You want to add more to it.

  Here are few CSS Resets that you can look at and use to create your own CSS Reset or just copy and paste one that already prebuilt.

  https://www.joshwcomeau.com/css/custom-css-reset/

  https://meyerweb.com/eric/tools/css/reset/

  http://html5doctor.com/html-5-reset-stylesheet/

  • For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.

  More Info:

  https://betterprogramming.pub/px-em-or-rem-examining-media-query-units-in-2021-e00cf37b91a9

  https://uxdesign.cc/why-designers-should-move-from-px-to-rem-and-how-to-do-that-in-figma-c0ea23e07a15

  Happy Coding!

  Marked as helpful

  1

  ---

  

  P

  Q-bert•210

  @QBERT18Posted about 2 years ago

  @vcarames Thank you very much. I will read about reset now and implement it. I have a question about the media queries. But how should i find out which em i should take? By just converting 1440px to em (that would make 1em)? Or are there any standard sizes to take?

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  @QBERT18

  You divide 1440 by 16 = 90em

  (16 value is the default size for the majority of browsers)

  If you're using VSCode you can download the extension px to rem and this covert them for you.

  0