product-preview-card-component-main

Community feedback

• 

  Ukaegbu Gray Nneji•220

  @graynnejiPosted over 1 year ago

  Congratulations I think you might want to learn more on typography.

  Typography is an important aspect of web design that involves the selection of fonts, font sizes, line heights, and other stylistic elements to improve the readability and visual appeal of text. Here are some tips for using typography in CSS.

  Line height: Use a line height that is appropriate for the font size and improves the readability of the text. A good rule of thumb is to use a line height of 1.5 to 1.6 times the font size. You can use the line-height property in CSS to specify the line height, like this:

  body {
  font-size: 16px;
  line-height: 1.5;
  }
  

  For smaller font you bigger line height while for bigger font you use a smaller line Height

  Letter spacing: Use letter spacing to improve the readability of the text. You can use the letter-spacing property in CSS to specify the letter spacing, like this:

  h1 {
  letter-spacing: 0.1em;
  }
  

  In this example, a small amount of letter spacing is added to the h1 element to improve the readability of the text.

  By following these guidelines, you can create effective typography in CSS that improves the readability and visual appeal of your text.

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
  • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
  • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="corpo"> element with the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0