Design comparison
Solution retrospective
While doing this challenge I had to do a lot of googling and actually take others' code sometimes. Am I doing it right or Should I just focus on mastering the required skills and then start doing projects? Please if someone could clarify.
Community feedback
- @correlucasPosted about 2 years ago
👾Hello Ashray, Congratulations on completing this challenge!
Your solution its almost done and I’ve some tips to help you to improve it:
You did a good work putting everything together in this challenge, something you can do to improve the image that needs to change between mobile and desktop is to use
<picture>
instead of<img>
wrapped in a div. You can manage both images inside the<picture>
tag and use the html to code to set when the images should change setting the devicemax-width
depending of the device (phone / computer) Here’s a guide about how to usepicture
:https://www.w3schools.com/tags/tag_picture.asp
See the example below:
<picture> <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg"> <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;"> </picture>
I saw that for some properties you’ve used
rem
and for otherspx
. In this case, it is better to use only one kind of unit to have a better organization for your code.relative units
asrem
orem
have a better fit if you want your site more accessible between different screen sizes and devices.REM
andEM
does not just apply to font size, but to all sizes as well.✌️ I hope this helps you and happy coding!
Marked as helpful2 - Account deleted
Hello Ashray 👋
I read your code and I noticed that you struggle a lot with reseting css properties of browser. At long that could be very painful so I recommend you to use a reset. You can find them on
Otherwise, congratulation for your achievement 🎉
Marked as helpful0 - @NestamashPosted about 2 years ago
If you googled a lot of properties in this project I would recommend mastering the basic CSS and by doing that you'll be able to be fast and learn new things such as accessibility. For instance, I managed to do this project without googling anything and so far I can say I'm learning a lot from the gurus here.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord