@correlucas
Posted
👾Hello Ashray, Congratulations on completing this challenge!
Your solution its almost done and I’ve some tips to help you to improve it:
You did a good work putting everything together in this challenge, something you can do to improve the image that needs to change between mobile and desktop is to use <picture>
instead of <img>
wrapped in a div. You can manage both images inside the <picture>
tag and use the html to code to set when the images should change setting the device max-width
depending of the device (phone / computer) Here’s a guide about how to use picture
: https://www.w3schools.com/tags/tag_picture.asp
See the example below:
<picture>
<source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
<img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
</picture>
I saw that for some properties you’ve used rem
and for others px
. In this case, it is better to use only one kind of unit to have a better organization for your code. relative units
as rem
or em
have a better fit if you want your site more accessible between different screen sizes and devices. REM
and EM
does not just apply to font size, but to all sizes as well.
✌️ I hope this helps you and happy coding!
Marked as helpful