product-preview-card-component-main

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

• I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

• This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

• So fix it by replacing the <div class="attribution"> with the semantic element <footer> in your index.html file to improve accessibility and organization of your page.

• What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

• For example:
  • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
  • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

CSS 🎨:

• Looks like the component has not been centered correctly due to static value of 880px. So let me share the suitable style rule,

main {
    min-height: 100vh;
}

• Now remove these styles, after removing you can able to see the changes

.procard {
   margin-top: 50px;
}

• Now your component has been properly centered

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Wrap <div class="attribution"> in the footer tag to fix the accessibility issue.

To center .procard on the page using flexbox, change the value of the min-height in the body to `100vh

main{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING