Skip to content
Submitted over 1 year ago

product-preview-card-component-main

ren-dani•40
@ren-dani
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Please give me some pointers, there are also other things I would've failed to notice because of my inexperience.

  1. I found sizing the image difficult, going from mobile to desktop -Naming classes and recognizing how to place the <div>.
  2. I'm unsure of : -How to style the original price, tried using <sup> but it did not look anything like the design.
/* Original price */
span {
    font-size: 0.875rem;
    padding: 1rem;
    text-decoration: line-through;
}
  • The icon on the card does not look whole.
/* icon cart on button */
button img{
    display: inline;
    margin-right: .5rem;
}

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    CSS 🎨:

    • Looks like the component has been centered properly. So let me explain, How you can easily center the component without using margin or padding.
    • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states
    • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.
    • For this demonstration we use css Grid to center the component
    body {
    min-height: 100vh;
    display: grid;
    place-items: center;
}

@media (min-width: 1004px)
.card {
  width: 43em;
}
    • Now remove these styles, after removing you can able to see the changes
    @media (min-width: 1004px)
.card {
  margin: 8rem 25rem;
}
    • Now your component has been properly centered

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord