Design comparison
Solution retrospective
Having to make the product image responsive
Community feedback
- @thrbngPosted about 2 years ago
Hi @Georgeinnerside , Congrats on your 2nd challenge
first of all u have a big problem with colors , so try to use the file "style-guide" to get the correct colors , and also get the correct
font-family and
font-width. Then u need to add a height to the body like "`100hv".Learn more about CSS and always keep learning
thr
Marked as helpful0@GeorgeinnersidePosted about 2 years ago@thrbng Thank you so much, I will work on that.
1 - @PPechmannPosted about 2 years ago
Hey George!
Congrats on your 2nd challenge, very well done!
I checked your code and saw that you centered the card with flexbox correct.
You only need to add a height to the
body
, in this case of100vh
to cover the full screen, This will perfectly center the card, if you get rid of the 15% margin.With Flexbox, the styles
align-items: center
andjustify-content: center
, work when a height is applied to the parent element.Hope this helps and looking forward to see more solutions from you.
Happy weekend and happy coding :)
Patrick
Marked as helpful0@GeorgeinnersidePosted about 2 years ago@PPechmann Thank you so much, I will work on. the corrections.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord