product-preview-card-component-main

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi Misa Dervisevic, congrats on completing this challenge!

  Great start and great first solution! You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code:

  1.For future projects, think about using relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices.

  2.THE PICTURE TAG is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Misa Dervisevic•150

  @DervisevicMPosted about 2 years ago

  @correlucas Hello Lucas, Thanks for your suggestions, I'll try the picture tag right away. 👍

  1

  

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  @DervisevicM Nice to hear that, keep it up with the good work Misa =)

  0