Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

product-preview-card-component-main

@Mitrandir666

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi, thanks for Yours feedback

Community feedback

@MaximilianoDanielGarcia

Posted

Hi Mitrandir, great job!

I have some suggestions for improvement that might help you.

  • Instead of having one image that is scaled up or down based on the viewport width, you can use <picture> tag. It gives you more flexibility in specifying image resources.
<picture>
  <source media="(width <= 465px)" srcset="images/image-product-mobile.jpg">
  <img src="images/image-product-desktop.jpg" alt="Perfume">
</picture>
  • You can use <main> and <section> tags for a better accesibility. The <main> tag specifies the main content of a document. The <section> tag defines a section in a document.

  • You forgot to add cursor: pointer; on hover button. The rest looks well.

I hope these are helpful to you.

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord