Design comparison
Solution retrospective
plz, gives feedback
Community feedback
- @githukelvinPosted over 2 years ago
Hey buddy
Seen you havent updated the screenshot of preview
- The
margin: 5rem auto 0 auto;
you can replace withmargin:10rem auto;
it will be exact of that of design.and that it is if you have addedmax-width:1440px;
on the body.
-Another feedback is the paragraph should have a
font-weight:500;
font-family:montserrat,sans serif. addline-height:1.5;
addwidth:80%;
-Another point is
<main class="container">
you could have useddiv
instead of the landmark. addalt=""
on your cart image accesibility respect heading from<h1></h1> to <h6></h6
in that order.Thats all @afaiz-space Happy coding Hope it is Helpful
2 - The
- @adebisiabdussamadPosted over 2 years ago
Cheers π₯ on completing this challenge.. .
An img element must have an alt attribute. This enables physical challenge to understand the image better.
This is your code is:
<img class=
cart_logosrc=
images/icon-cart.svg><span>
This is how it should have been:<img class=
cart_logosrc=
images/icon-cart.svgalt="the picture in text"><span>
your code is really amazing...hope you find this helpful... Happy coding!!!ππ
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord