Design comparison
Solution retrospective
Any comments or suggestions are welcome! :)
Community feedback
- @elaineleungPosted over 2 years ago
Hi Elisavet, well done on your component, and since no one has commented yet, I'll be the first :) You can try adding some padding in the mobile view either on your body or on a new container div because the sides of your component are touching the viewport on my browser. Also, try changing the line height on your product name title to something like 1.1 instead of the 1.5 on the body; that might look closer to the design instead. Lastly, I probably would use the
<h1>
tag on the product name instead of the category name. The <h1> helps to inform search engines what the page is about, and so you typically would want to have the most important info or title that describes the content. Heading tags don't necessarily have to go in order of structure; it's best to have them in the order of importance.Hope this helps!
Marked as helpful0@elisavet12Posted over 2 years ago@elaineleung Thank you very much for your feedback!! :) It was very helpful!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord