Product-preview-card-component-main

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted over 2 years ago

  Hi

  This seems a bit rushed. It''s got explicit heights and widths meaning this will break for any users who resize their font/zoom settings. Test what I mean by setting your browser to 'zoom text only' then zoom in on desktop. You will see content spill out of the card.

  There is rarely a good reason to limit height, which is why we recommend min-height instead.

  I also recommend against using input type button. That's a deprecated element from before the button element existed! And anyway, looking at this design, I don't think it would be a button at all, it would be an anchor tag.

  Really take your time and think through the html carefully.

  Last thing - the image gets distorted in some views. Check out the object-fit property!

  Marked as helpful

  0

  ---

  

  Yous•170

  @yousra10Posted over 2 years ago

  @grace-snow Hi Grace, Thank you very much for your comments. I remove the `min-width: 100vw; I replace the input button by an anchor tag. I will learn about input and anchor tag. Thank you for the object-fit property. Thank you Grace for your feedback, it helps me improve...

  0