Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product-preview-card-component Using HTML & CSS

Mazen Ahmedā€¢ 30

@Mazen922

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I just finished from Product-preview-card-component Challenge šŸ˜ƒ

and I really need you feedback šŸ˜

Community feedback

Daniel šŸ›øā€¢ 44,230

@danielmrz-dev

Posted

Hello @Mazen922!

Your project looks great!

I have one suggestion for you to improve it even more:

  • Using margin is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:

šŸ“Œ Apply this to the body (in order to work properly, don't use position or margins):

body {
    min-height: 100vh;
    display: flex;  /* it works with grid too  */
    justify-content: center;
    align-items: center;
}

I hope it helps!

Other than that, great job!

Marked as helpful

0

Mazen Ahmedā€¢ 30

@Mazen922

Posted

Thanks @danielmrz-dev

it helped me a lot. šŸ˜Š

1
Luis Riveroā€¢ 100

@LJRiveroPastrana

Posted

well done! take a look of style guide and use the right tipography, that will look better the design.

Marked as helpful

0

Mazen Ahmedā€¢ 30

@Mazen922

Posted

Hi @LJRiveroPastrana

I did try to make the same font but I couldn't because it's not at Google Fonts these days, maybe it is too old and they deleted it.

Thanks šŸ˜Š

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord