Design comparison
SolutionDesign
Solution retrospective
I just finished from Product-preview-card-component Challenge š
and I really need you feedback š
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @Mazen922!
Your project looks great!
I have one suggestion for you to improve it even more:
- Using
margin
is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:
š Apply this to the body (in order to work properly, don't use position or margins):
body { min-height: 100vh; display: flex; /* it works with grid too */ justify-content: center; align-items: center; }
I hope it helps!
Other than that, great job!
Marked as helpful0 - Using
- @LJRiveroPastranaPosted 9 months ago
well done! take a look of style guide and use the right tipography, that will look better the design.
Marked as helpful0@Mazen922Posted 9 months agoHi @LJRiveroPastrana
I did try to make the same font but I couldn't because it's not at Google Fonts these days, maybe it is too old and they deleted it.
Thanks š
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord