Product-preview-card-component using grid and flexbox.

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  PiCTURE TAG 📸:

  • Looks like you're currently using media queries for swapping different version of image, So let me introduce the picture element.

  ---

  • The <picture> tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.

  ---

  • Example:

  <picture>
    <source media="(max-width: 768px)" srcset="small-image.jpg">
    <source media="(min-width: 769px)" srcset="large-image.jpg">
    <img src="fallback-image.jpg" alt="Example image">
  </picture>
  

  ---

  • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.

  ---

  • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  2

  ---

  

  NugyTomas•220

  @NugyTomasPosted over 1 year ago

  Thanks alot! @0xAbdulKhalid

  0
• Account deleted

  Nice work ✨, congratulations

  here is some suggestions for your code:

  • you can remove the first div tag, and take the flex-container class's design to the body design in style.css file
  • you should write min-height: 100vh; instead of height: 100vh; to make sure that the body will expand if the height is more than the screen height
  • I think you should remove image-container's div tag, why do you need it ?
  • you should minimize the size of tags in the mobile screens, you can use percentage instead of pixel units
  • you should replace each div tag with HTML5 sematic tags, like: <main>, <section>, <header>, <footer> and go on

  Good luck in the next challenges, keep going on 🔥

  Marked as helpful

  1

  ---

  

  NugyTomas•220

  @NugyTomasPosted over 1 year ago

  I started to use these tips! Thank u. @MasterMousa

  1