Skip to content
Submitted about 2 years ago

Product-preview-card-component

Mzu Soci•170
@Mzu-Soci
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Centering a div vertically. Media queries confused me a little Understanding max width requirements and their relationship with media queries

Community feedback

  • Faisal Alharbi•330
    @LovelyFaisalPosted about 2 years ago

    Hi! You've done great 💪

    Here are some suggestions to improve your code:

    You can center the div vertically using flexbox add to body element this property:

    body {
    height: 100vh;
    display: flex;
    align-items: center;
}

    to center it horizontally add justify-content: center; to body also

    you can learn more about flexbox Here

    • Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.

    Click here for more information

    Good job, and happy coding!

    Marked as helpful
    0
  • Adriano•38,390
    @AdrianoEscarabotePosted about 2 years ago

    Hi Mzu Soci, how are you?

    Welcome to the front-end mentor community!

    I really liked the result of your project, but I have some tips that I think you will enjoy:

    • We have to make sure that all the content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    The rest is great!

    I hope it helps... 👍

    0
  • バレンタイン 😈•64,170
    @VCaramesPosted about 2 years ago

    Hey there! 👋 Here are some suggestions to help improve your code:

    • To center you content to your page, add the following to your Body Element:
    body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}
    • For this challenge you want to use the Picture Element not the Background Image Property. The Background Image Property is mainly used on decorative images

    Picture Element will allow your to switch between images in different breakpoints and makes your site load faster by saving bandwidth.

    Here is an example of how it works: EXAMPLE

    Syntax:

      <picture>
    <source media="(min-width: )" srcset="">
    <img src="" alt="">
  </picture>

    More Info:

    https://www.w3schools.com/html/html_images_picture.asp

    https://web.dev/learn/design/picture-element/

    If you have any questions or need further clarification, let me know.

    Happy Coding! 👻🎃

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord