Skip to content
Submitted about 2 years ago

Product-preview-card-component

Justin•50
@stwslim83
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I finished another challenge! Any advice, good or bad would be appreciated :-)

Community feedback

  • Jeck•1,080
    @j-tomajinPosted about 2 years ago

    hello,

    on the perfume image, you can use <picture> element.

    example:

    <picture> <source media="(min-width: 500px)" srcset="./images/image-product-desktop.jpg"> <img src="./images/image-product-mobile.jpg" alt=""> </picture>

    this code automatically switches between picture/img with the given min-width.

    HAPPY CODING! :)

    Marked as helpful
    1
    Justin•50
    @stwslim83Posted about 2 years ago

    @AsukalDePapa that helps alot, I wasn't sure if i should be using "picture" or "img". Using "picture" and then setting a "min-width" will be helpful. Thanks for the comment! :-)

    1
  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted about 2 years ago

    Hi @stwslim83 👋, good job completing this challenge! 🎉

    I have some suggestions you might consider to improve your code:

    • Use the <main> tag to wrap all the main content in your solution instead of using <article class="full-wrapper">.
    • Use <footer> instead of <div class="attribution">. The <footer> element contains authorship information.
    • The cart icon is for decoration purposes only, so it can be hidden from screen-readers by adding aria-hidden="true" and leaving its alt attribute empty.
    • Should I have used the picture element instead of "IMG"? / Yes, you can use a <picture> tag when you need to change an image in different viewports. Using this tag will prevent the browser from loading both images, saving bandwidth and preventing you from utilizing a media query in your CSS file to modify the image.

    Example:

    <picture>
   <source media="(max-width: 650px)" srcset="./images/image-product-mobile.jpg">
   <img src="./images/image-product-desktop.jpg" alt="your_alt_text">
</picture>
    • You could use the <del> tag to display the old price:
    <del>
   <span class="sr-only">Old price: </span>$169.99
</del>

    Note that I added the <span> with the sr-only class to the del element, this will provide more information about what your old price is about.

    The sr-only class is a class that you can add to hide content visually but is only visible to screen-readers.

    More information here.

    I hope those tips will help you! 👍

    Good job, and happy coding! 😁

    Marked as helpful
    0
    Justin•50
    @stwslim83Posted about 2 years ago

    @MelvinAguilar thanks for the comment, i'll def try incorporating some of this stuff in my next project :-)

    1
  • Adriano•38,120
    @AdrianoEscarabotePosted about 2 years ago

    Hi Justin, how are you?

    I really liked the result of your project, but I have some tips that I think you will enjoy:

    We have to make sure that all the content is contained in a reference region, designated with HTML5 reference elements.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    The rest is great!

    I hope it helps... 👍

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord