Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product-preview-card-component

@kwakner

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Comments and Contributions are welcome

Community feedback

@rohitd99

Posted

Hi Amenyo

Congrats on completing the challenge.

I found that you had height: 100% on your body and overflow: hidden. These properties stopped your card from expanding on mobile sizes. Instead use min-height: 100vh so that body expands as per the content. Also instead of using a div to wrap the card I'd suggest using main as it is a semantic element.

I also noticed that you've used the s strikethrough element for the old price but as per MDN docs , it is no longer relevant to use it. The element del would be a better choice. Here is a link to MDN.

Hope it helps

Marked as helpful

0

@kwakner

Posted

thank you for the review and feedback. I appreciate@rohitd99

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord