Product-preview-card-component

Community feedback

• 

  Rohit Deshpande•870

  @rohitd99Posted over 1 year ago

  Hi Amenyo

  Congrats on completing the challenge.

  I found that you had height: 100% on your body and overflow: hidden. These properties stopped your card from expanding on mobile sizes. Instead use min-height: 100vh so that body expands as per the content. Also instead of using a div to wrap the card I'd suggest using main as it is a semantic element.

  I also noticed that you've used the s strikethrough element for the old price but as per MDN docs , it is no longer relevant to use it. The element del would be a better choice. Here is a link to MDN.

  Hope it helps

  Marked as helpful

  0

  ---

  

  Amenyo Xornam Francis•170

  @kwaknerPosted over 1 year ago

  thank you for the review and feedback. I appreciate@rohitd99

  0