Product-preview-card-component

Community feedback

• 

  Don•220

  @coffeeslammerPosted over 1 year ago

  I can give you a couple tips. look into <Picture> element. and srcset. It will resize your picture for you The Perfume should be your H1. Think of your H's as a file structure. If they were folders H1 is the root folder and all other H's are sub-folders. Perfume would be the main folder and brands would be stored in that folder (figuratively speaking). The brand here would be a <P>. Also its always recommended to use CSS to do uppercase. I'm still learning but I think the reason is some screenreaders will read each letter instead of the word. Use text-transform in CSS. Hope this helps on your learning journey.

  Marked as helpful

  1

  ---

  

  Oluwafemi Kolade•230

  @Kolade1024Posted over 1 year ago

  Thanks for the tips. I'll start using the text-transform property, I'm not really used to it. Also can I have your Twitter handle or whatever I can use to connect with you. @coffeeslammer

  0

  

  Don•220

  @coffeeslammerPosted over 1 year ago

  @Kolade1024 sorry I don't have any social media such as twitter. If you haven't I'd highly recommend joining the discord channel. The people there are really helpful.

  0

  

  Oluwafemi Kolade•230

  @Kolade1024Posted over 1 year ago

  Alright@coffeeslammer

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly in desktop mode. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  @media screen and (min-width: 1200px)
  main {
  margin: 5rem auto;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1

  ---

  

  Oluwafemi Kolade•230

  @Kolade1024Posted over 1 year ago

  Thanks a lot for this. It totally skipped my mind to center the component@0xAbdulKhalid

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @Kolade1024 Glad you found it helpful ! 🤠

  1