Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product-Preview-Card-Component

@olivervillalobos

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

.

What challenges did you encounter, and how did you overcome them?

.

What specific areas of your project would you like help with?

.

Community feedback

Bryan Li 3,550

@Zy8712

Posted

Your site looks pretty good. The main things I'd add/change are:

  • adding <main> tags to wrap around your page's main content for accessibility purposes
  • instead of using position absolute to position your box, use something like flexbox to center it. So you would need to assign flexbox to the parent container of your card, which in this case would be the body. So it could look something like this:
body {
    min-height: 100vh;
    display: flex;
    flex-direction: column;
    justify-content: center;
    align-items: center;
}
  • one other thing worth mentioning is that you should probably wrap some of your text in header tags such as <h1> and <h2> as opposed to all of them being in <p> tags. This is due to how screen readers and search engines will treat header tags slight differently than standard text

Hope you find this feedback useful 👍

Marked as helpful

1

@olivervillalobos

Posted

Thank you for your feedback, I'll add what you mention in my code and get back to you, I really appreciate your time :). @Zy8712

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord