Bryan Li• 3,550
@Zy8712
Posted
Your site looks pretty good. The main things I'd add/change are:
- adding
<main>
tags to wrap around your page's main content for accessibility purposes - instead of using position absolute to position your box, use something like flexbox to center it. So you would need to assign flexbox to the parent container of your card, which in this case would be the body. So it could look something like this:
body {
min-height: 100vh;
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
}
- one other thing worth mentioning is that you should probably wrap some of your text in header tags such as
<h1>
and<h2>
as opposed to all of them being in<p>
tags. This is due to how screen readers and search engines will treat header tags slight differently than standard text
Hope you find this feedback useful 👍
Marked as helpful
1