Product-preview-card-component

Community feedback

• 

  Miran Legin•680

  @miranleginPosted about 2 years ago

  Hi Lenez,

  congratulations on completing this challenge! You did a great job here and there are only couple of tweaks to make it even better in my opinion.

  1. remove the height on main element, you will see that the text__content is no longer nicely spaced vertically so you can fix it by adding padding to top and bottom sides od text__content
  2. you can replace the product__image div with picture element and put inside both images for mobile and desktop versions accordingly. there is an example on my channel regarding this technique and you can learn more information on this article Picture element with art direction
  3. as you already have border-radius declared on main tag, you don't need to declare it once again on product-image, just add overflow:hidden to hide anything that might stick outside of it

  Keep coding!

  1
• 

  Lenez•440

  @lenez12Posted about 2 years ago

  Thanks Miran, in the third point doesn't the mobile version have a different border-radius position? so if I make overflow:hidden then it is not as expected on the mobile display.

  0