product-preview-card-component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to incorrect usage of semantic markup, which causes lacking of landmark for a webpage

  ---

  • So fix it by wrapping the <section> elements with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  CSS 🎨:

  • Looks like the component has not been centered correctly, along with that you have overused the absolute position property. I tried my best to optimize the look in my browser, but unfortunately it's not possible.

  ---

  • I recommend you to take a look at my solution to know how i able to efficiently handle the layout

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1

  ---

  

  Rachid El Barqouqy•190

  @rachpro1234Posted over 1 year ago

  @0xAbdulKhalid yes this comment means a lot actually, as well as the first one in the other component. Your remarques are truly right and I'll be trying to fix those things and start generating my code to be more semantic and readable. Thank you

  0