Product-preview-card-component

Community feedback

• 

  Luka Glonti•3,440

  @lack21Posted over 1 year ago

  Good job 👍, but I have some recommendations!

  • Remove width: 100vw from the main, main is a block level element which by default takes full width available, so width: 100vw does nothing here!

  • Replace height: 100vh to min-height: 100vh in the main, the difference is that, when you set height: 100vh to something, that means it won't be bigger than that, it might cause some problems in the future, so better approach is to set min-height: 100vh, like this in case content is overflowing container will adjust to it!

  • You have these styles

  * {
    margin: 0px;
    padding: 0px;
  }
  

  you can just write margin: 0 and padding: 0 there's no need for px!

  0