Design comparison
Solution retrospective
It's my first program, it's not difficult, just need a lot of independent thinking, I can do better! The difficulties for me is trying to fit the img to a flexible size, I think I need some thought and practice for it.
Community feedback
- @HassiaiPosted over 1 year ago
Replace <section class="preview"> with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html
To center .container on the page using flexbox or grid instead of giving .preview a padding value, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
To center .container on the page using flexbox: body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
To center .container on the page using grid: body{ min-height: 100vh; display: grid; place-items: center; }
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0@TianYeCalPosted over 1 year ago@Hassiai Thank you so much! I will do it again, appreciate it!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord