Design comparison
SolutionDesign
Community feedback
- @MukarramHaqPosted 6 months ago
Hey, great work!
I would like to point out a few things:
HTML:
- In your
<body>
put everything inside the<main>
tag for this particular project. It specifies the main content of the page. - Always have something in you
alt
for an image. You can say something like Chanel Parfum <br>
tags should be avoided write the whole sentence in one line.- In your
<button>
tag you can give the source of the SVG that you downloaded with this project it should beimages/icon-cart.svg
CSS:
- In
.image
never use px for width. Always yourrem
. - The
font-size
should never be inpx
userem
for that as well - In
button
remove the borders byborder:none
.
This is all I could help you with with my limited knowledge. I hope you find this useful :)
0 - In your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord