product-preview-card-component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  PiCTURE TAG 📸:

  • Looks like you're currently using single image for both Desktop & Mobile devices, but we want to swap images according to their screen sizes. Luckily there's a native html element which may help us to achieve this method without need of css

  ---

  • So let me introduce the picture element.

  ---

  • The <picture> tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.

  ---

  • Example:

  <picture>
  <source media="(max-width: 768px)" srcset="small-image.jpg">
  <source media="(min-width: 769px)" srcset="large-image.jpg">
  <img src="fallback-image.jpg" alt="Example image">
  </picture>
  

  ---

  • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.

  ---

  • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  ElleCh9•160

  @ElleCh9Posted over 1 year ago

  @0xAbdulKhalid Hi Abdul, You were really great in explaining how to use different images based on screen size. Thanks to your advice, I present the improved solution again. ^^

  0
• 

  Rohit Deshpande•870

  @rohitd99Posted over 1 year ago

  Hi ElleCh9

  Congrats on completing the challenge.

  A few suggestions I hope can help you,

  • Add the following properties on body

  min-height: 100vh;
  display: grid;
  place-content: center;
  

  these will help keep the content centered and also on mobile view the content may expand more than the screen size. Remove the margins on the container for the desktop view.

  • I noticed you have used h2 for the title of perfume , use an h1 instead since each page needs a h1 and you can style it as per need. Also headings always need to be from h1 through h6 in sequence according to semantics.
  • You also have changed the grid to flex for mobile view, you can actually achieve the same without changing the grid but instead only adding grid-template-columns: auto; instead.
  • You also need to change the border-radius of description-article in the mobile view, to border-radius: 0 0px 15px 15px;
  • Use the del element for the old price, it provides more meaning and default strikethrough style.

  Hope it helps

  Marked as helpful

  0

  ---

  

  ElleCh9•160

  @ElleCh9Posted over 1 year ago

  @rohitd99 Wow!! I will make the suggested changes to see the result. Thanks for the advices.

  0