Design comparison
Solution retrospective
i'm trying to improve my skills please rate me and guys if u have any advice for me
Community feedback
- @MelvinAguilarPosted 11 months ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
-
Wrap the page's whole main content in the
<main>
tag. -
You can use the
<picture>
tag when you have different versions of the same image ๐ผ. Using the<picture>
tag will help you to load the correct image for the user's device saving bandwidth and improving performance. You can read more about this here ๐.Example:
<picture> <source media="(max-width: 460px)" srcset="./images/image-product-mobile.jpg"> <img src="./images/image-product-desktop.jpg" alt="{your alt text goes here}"> </picture>
- Consider using a button instead of an anchor tag for the "add to cart" element, as buttons are designed for actions like adding a item to a cart of products. Anchors are typically used for linking In this instance, the action involves adding the product to the cart, making a button a more fitting choice.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord