Design comparison
Solution retrospective
I didn’t have any major issues but any suggestions for improvement would be greatly appreciated, Jack
Community feedback
- @rayaattaPosted 10 months ago
Hello 👋Jack-OC, congratulations on completing this challenge 🎉
I have one suggestion you might find interesting.
I noticed
<span class="original-price"> $169.99</span>
this was decorated in css with a stroke showing it with s no longer a valid price.this is nice but user's using assistive technology Will not know that the price has been reduced a more Semantic alternative would be the<s>
element. You can learn more about it here.I hope this helps 🙃
Your solution is awesome 👏,I like the way it is extremely concerned about semantics and accessibility 🤩
Happy coding bro✌️
Marked as helpful0@Jack-OCPosted 10 months agoHey, @rayaatta Thank you for the suggestion to make my solution more accessible. I wouldn’t have thought about how to make it more clear for assistive technology in that case. I will definitely think about that more when tackling more of these challenges in the future. Thanks for feedback, Jack
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord