Design comparison
SolutionDesign
Solution retrospective
Feedback welcome
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @ArunaChandru!
Your project looks great!
I have one suggestion for you to improve it even more:
- Using
margin
is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:
š Apply this to the body (in order to work properly, don't use position or margins):
body { min-height: 100vh; display: flex; /* it works with grid too */ justify-content: center; align-items: center; }
I hope it helps!
Other than that, great job!
0 - Using
- @pravinkoriPosted 9 months ago
-
Semantic Structure: Use semantic HTML elements to improve the structure and accessibility of the document. For example, consider using <header>, <main>, <section>, <article>, and <footer> where appropriate.
-
CSS Styling: Instead of inline styles, move the styles defined in the
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord