product-preview-card

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello @Babsman123, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  1.The image is not responsive yet, a quick way to make any image responsive and respecting the container size is to add display: block and max-width: 100% to the <img> selector. To improve the responsiveness even more adding the auto-crop property you can add object-fit: cover to make the image crop inside the container its inside.

  img {
      display: block;
      object-fit: cover;
      max-width: 100%;
  }
  
  
  2.Use the **THE PICTURE TAG** that is a shortcut to deal with the multiple images in this challenge. So you can use the  `<picture>` tag instead of importing this as an `<img>`  or using a div with `background-image`. Use it to place the images and make the   change between mobile and desktop, instead of using a `div` or `img` and set the change in the css with `display: none` with the tag picture is more practical and easy. Note that  for **SEO / search engine** reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the `<picture>` tag and use the html to code to set when the images should change setting the device `max-width` depending of the device **desktop + mobile**. 
  
  Check the link for the official documentation for `<picture>` in **W3 SCHOOLS**:
  [`https://www.w3schools.com/tags/tag_picture.asp`](https://www.w3schools.com/tags/tag_picture.asp)
  
  See the example below:
  

  <picture> <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg"> <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;"> </picture> ```

  👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @Babsman123, some suggestions to improve you code:

  • The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.

  • This challenges requires the use of two images 🎑 for different breakpoints. The Picture Element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:

  https://www.w3schools.com/html/html_images_picture.asp

  https://web.dev/learn/design/picture-element/

  • There is only one heading in this challenge and that is the name of the perfume, “Gabrielle Essence Eau De Parfum”.

  • The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.

  Happy Coding! 👻🎃

  0