Product-Preview-Card

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  There is no need to give the body a max-width and a margin value.

  To center .card on the page using flexbox or grid instead of margin,

  • USING FLEXBOX: add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body

  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  • USING GRID: add min-height:100vh; display: grid place-items: center to the body

  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  For a responsive give .card a max-width, max-width: 500px , there is no need to give to .card a height value rather give . review the same padding value for all the sides.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  manjubhaskar02•340

  @manjubhaskar02Posted over 1 year ago

  @Hassiai , Thankyou for the suggestions and helping me to correct my mistakes. I always failed in centering the body, and used grid to center the body, but in confusion , I gave margin and all. Thankyou for the time you took to read my code and helping me.

  1