Product-preview-card

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • For this challenge you want to use the Picture Element not the Background Image Property. The Background Image Property is mainly used on decorative images

  Picture Element will allow your to switch between images in different breakpoints and makes your site load faster by saving bandwidth.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:

  https://www.w3schools.com/html/html_images_picture.asp

  https://web.dev/learn/design/picture-element/

  • Remove all the Line Break Elements you added. They are unnecessary.

  • The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include span element with an sr-only text explaining that this is the old price.

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  Marked as helpful

  0
• 

  Faisal Alharbi•330

  @LovelyFaisalPosted about 2 years ago

  Hi lordvitor11! You've done great 💪

  Here are some suggestions to improve your code:

  • Use letter-spacing property to add spacing between letters

  The letter-spacing property increases or decreases the space between characters in a text.

  Click here for more information

  Good job, and happy coding!

  Marked as helpful

  0