Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product-preview Card

@ayushprojects

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello everyone I have completed the product preview task. comment the mistakes that I have made and suggest some writing tips. thankyou

Community feedback

@sasanqc

Posted

Hi, Congrats for your submission

  1. use rem unit instead of px for responsiveness.
  2. do not use id for addressing elements. use class as much as is possible
  3. do not use div if it is not neccessary. it makes your html unreadable like this:
<div class="butn"> 
             <button id="btn">  
               <img src="images/icon-cart.svg" alt="icon" id="icon">
              Add to Cart</button></div>
        
  1. use an editor formatter like prettifier in vscode to make your code more readable
  2. use your own screenshot for readme file. not the frontendmentor's screenshot.

you can check my solution for more help.

Marked as helpful

0

@ayushprojects

Posted

@sasanqc thanks for your suggestion. I will Definitely try this approach.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord