Design comparison
SolutionDesign
Solution retrospective
Hello everyone I have completed the product preview task. comment the mistakes that I have made and suggest some writing tips. thankyou
Community feedback
- @sasanqcPosted almost 2 years ago
Hi, Congrats for your submission
- use rem unit instead of px for responsiveness.
- do not use id for addressing elements. use class as much as is possible
- do not use div if it is not neccessary. it makes your html unreadable like this:
<div class="butn"> <button id="btn"> <img src="images/icon-cart.svg" alt="icon" id="icon"> Add to Cart</button></div>
- use an editor formatter like prettifier in vscode to make your code more readable
- use your own screenshot for readme file. not the frontendmentor's screenshot.
you can check my solution for more help.
Marked as helpful0@ayushprojectsPosted almost 2 years ago@sasanqc thanks for your suggestion. I will Definitely try this approach.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord