Design comparison
Solution retrospective
Hello guys..! just completed this challenge, all feedback welcomed!
- I don't understand why the image doesn't fit in completely at the top, and my font isn't the same. If there is anything I could do better please let me know in your reviews :) !
Community feedback
- @AbdelmigedPosted over 1 year ago
Hello @04leslie, Congratulations on completing this challenge.π
-
When I looked at the code I found that you have put the image in a div called card-image, although you set the image to height: 100%, the image will consume 100% of it's direct parent which is the div with class of card-image, while it's direct parent is not set to height: 100% of it's direct parent which is the div with class of card.
-
As for the font, you have imported different font weights than those specified in the style-guide, for Fraunces it's weight is 700 while for Montserrat it's weights are 500 and 700.
-
You can also use colors that are the same as the design which will help a lot, there are tools like Instant Eyedropper which you can use to get the exact color of the text by hovering over the design image.
I hope this was helpful, and always remember practice makes perfect.π
Happy Coding
Marked as helpful0 -
- @jesusfrancisco88Posted over 1 year ago
Hi leslie! β¨ you could try to add this =>
overflow:hidden
to.card-image .img { ... }
0 - @moncadadPosted over 1 year ago
The approach I took on my project was for the .card { max-width: 600px } and went on to .card-image .img{ width: 100%} .card-info {width: 100%} and just made up for the remaining space with padding, and margin.
I found this video very helpful for understanding responsiveness. https://www.youtube.com/watch?v=VQraviuwbzU Hope it helps :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord