product-preview

Community feedback

• 

  P

  Mason Dunn•100

  @mason-dunnPosted over 2 years ago

  Hi,

  Your Github link appears to be broken. I'd be more than happy to take a look at your code once it gets fixed.

  0

  ---

  

  P

  Mason Dunn•100

  @mason-dunnPosted over 2 years ago

  @mason-dunn Here is some feedback after looking through your code from the developer tools:

  1. Use semantic html tags. I noticed that you use <p> for all text. Instead of using <p> for your title and main-title it would be more appropriate to use h1-h6 tags.

  2. Look into flexbox and css grid to learn how to position your card and its corresponding children where you want them easier. I noticed you have a margin-left on your card that pushes it where you want.

  3. Research some responsive design practices to come back and improve upon this in the future. You have a solid foundation here and after doing some research you can get this function on mobile devices too.

  Good work.

  0