product-page-project

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can properly center the component with the help of single style rule

  ---

  • You already using Flexbox for layout, but you didn't utilized it's full potential. Just add the following rules to properly center the component.

  ---

  .container {
      min-height: 100vh;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .container {
    margin: 30px auto;
    padding: 0 30px;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Ishan Narayan Shrestha•90

  @ishan-shresthaPosted over 1 year ago

  @0xAbdulKhalid I really appreciate for having time to look over my code and it will help me to progress 💪🏼

  0