
Design comparison
Solution retrospective
It would be nice if anyone can share valuable feedback. Regards, Tanvir.
Community feedback
- @Namonaki0Posted over 1 year ago
Hi TANVEER, well done for completing the challenge.
A few points I would like to mention:
Instead of having a div with a class of main you could have the <main> tag and make that the main wrapper.
You can center it in the middle of the page with the below:
main { display: grid; height: 100vh; place-content: center; }
I can see that you haven't included any media queries which would make your design responsive. I would use the mobile-first approach and then work my way up by using a media-query with a min-width for a chosen breakpoint, most likely 1440px as specified.
Just a few points to consider. I hope this helps.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord