product-card-component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here is some feedback to further improve your code:

  • This **LINK is not necessary ⚠️.

  • The image’s alt tag description needs to be improved upon ⚠️. Assume that you are describing the image to someone over the phone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The old price (169.99) 🏷 is not being properly announced 😢 to screen readers. To fix this, you are going to wrap the the price in a s element and inside it you will add a span element with an visually-hidden class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  More Info:📚

  The Strikethrough Element

  • For improved accessibility 📈 for your content, it is best practice ✅ to use em for media-queries. Using this unit gives users the ability to scale elements up and down, relative to a set value.

  If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  Happy Coding! 👾

  1

  ---

  

  Mohamed Atef•230

  @MohamedatePosted almost 2 years ago

  @vcarames Thanks a lot I will fix that 💜

  1

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @Mohamedate

  Glad I could help!

  0